Fix: Incorrect page size on screenshot in full-page mode in Chrome headless(closes #5961) #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyBelym
approved these changes
Jun 8, 2022
Artem-Babich
force-pushed
the
BabichA-dev-3
branch
from
87ca2ce
to
c56524c
Compare
AndreyBelym
force-pushed
the
BabichA-dev-3
branch
from
c56524c
to
88051b4
Compare
|
Excellent job! |
|
Release v2.1.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For some reason in chrome:headless page body size is set incorrectly.
Approach
Update devtools-protocol package and use the native screenshot approach.
References
Closes #5961
Closes #7224
Pre-Merge TODO