-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to load config file from cjs file #7614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
Please fix lint errors - https://github.com/DevExpress/testcafe/actions/runs/4654867081/jobs/8236970726 |
I fixed lint errors ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix server tests.
It's done. However, It is not possible to ensure that the whole of tests is ok because it seems not possible to be executed on local env. Isn't it? Regards, |
It's possible. I see a lot of excessive formatting changes in the current version of the commit. Please roll back these changes. |
Hi, I fixed again lint issues... :( |
You still have a few ESLint errors. Please fix them. |
At present, there is an issue with building a docker image. We will update this thread once it is fixed. |
The last issue is due to an invalid content in Docker image. Indeed, the content of
And expected should be
So, the configurations made with I don't know how to fix it... |
Rebase please. |
Hi @miherlosev
Regards, |
I see that all tests are green. I will ask our technical writers to update the documentation. As soon as it is ready, I will merge this PR. |
;) |
Release v2.6.0-rc.1 addresses this. |
[closes #6911]
Purpose
The newest NodeJS version requires indicating modules loading framework to use (CommonJS or ESM) by using extension file.
.js
extension is now for using ESM and.cjs
for CommonJS.Currently, from newest NodeJS, it is not possible to use CommonJS framework for TestCafe global configuration file (
.testcaferc.js
), because this file has to be named.testcaferc.cjs
Approach
This PR allows loading
.testcaferc.cjs
as TestCafe global configuration file.