Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload files with required inputs in native automation #8092

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

Bayheck
Copy link
Collaborator

@Bayheck Bayheck commented Nov 26, 2023

Purpose

UploadAutomation is fixed in order to upload required inputs in Native Automation mode.

Approach

Remove the required attribute from the file input before uploading.
Initialize the addInternalEventAfterListener on inputs form 'submit' event for returning the required attributes back.

References

closes #8079

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Nov 26, 2023
@aleks-pro aleks-pro removed the STATE: Need response An issue that requires a response or attention from the team. label Nov 27, 2023
Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please look at my comments

src/client/automation/playback/upload.js Outdated Show resolved Hide resolved
src/client/automation/playback/upload.js Show resolved Hide resolved
Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@Bayheck Bayheck merged commit ea902cb into DevExpress:master Nov 29, 2023
20 checks passed
Copy link

Release v3.5.0-rc.1 addresses this.

1 similar comment
Copy link

Release v3.5.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeAutomation: File upload doesn't work with a required attribute
4 participants