Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plan output on error #215

Merged
merged 7 commits into from
May 26, 2024
Merged

fix: plan output on error #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b6a8511
fix plan output on error
rdhar May 26, 2024
53bf4e4
debug print `process.env.tf_plan_outline`
rdhar May 26, 2024
eeebd27
debug print
rdhar May 26, 2024
5eac38e
debug print
rdhar May 26, 2024
64f66e6
debug print
rdhar May 26, 2024
4b0b798
explicit boolean check of `tf_plan_outline`
rdhar May 26, 2024
6cd8487
clean up debug
rdhar May 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ runs:
tf_fmt: ${{ steps.render.outputs.tf_fmt }}
tf_output: ${{ steps.render.outputs.tf_output }}
tf_plan_id: ${{ steps.arguments.outputs.tf_plan_id }}
tf_plan_outline: ${{ inputs.plan_outline && steps.plan.outcome == 'success' }}
tf_plan_outline: ${{ steps.plan.outputs.exitcode == 0 && inputs.plan_outline }}
with:
retries: 3
script: await require(`${process.env.GITHUB_ACTION_PATH}/scripts/comment_tf_output.js`)({ github, context, core, exec });
Expand Down
2 changes: 1 addition & 1 deletion scripts/comment_tf_output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ${process.env.tf_fmt}

// Parse the TFplan file to extract an outline of changes.
let comment_outline = "";
if (process.env.tf_plan_outline) {
if (process.env.tf_plan_outline === "true") {
// Parse TFplan file.
let tfplan = "";
const data_handler = (data) => {
Expand Down
Loading