Fix IEEE preview does not display month (JabRef#3239)

Make change direct on bibTeXEntry instead of creating a copy of bibEntry
DevSiroukane · Apr 29, 2018 · 82b05d1 · 82b05d1
1 parent 2f022b2
commit 82b05d1
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/src/main/java/org/jabref/logic/citationstyle/CSLAdapter.java b/src/main/java/org/jabref/logic/citationstyle/CSLAdapter.java
@@ -84,29 +84,26 @@ private static class JabRefItemDataProvider implements ItemDataProvider {
         /**
          * Converts the {@link BibEntry} into {@link CSLItemData}.
          *
-         * Clone bibEntry to make a save changes,
          * Change month field from JabRefFormat <code>#mon#</> to ShortName <code>mon</code>
          * because CSL does not support JabRefFormat.
          */
         private static CSLItemData bibEntryToCSLItemData(BibEntry bibEntry) {
-
-            bibEntry = (BibEntry) bibEntry.clone();
-
             String citeKey = bibEntry.getCiteKeyOptional().orElse("");
             BibTeXEntry bibTeXEntry = new BibTeXEntry(new Key(bibEntry.getType()), new Key(citeKey));
 
             // Not every field is already generated into latex free fields
             HTMLChars latexToHtmlConverter = new HTMLChars();
             RemoveNewlinesFormatter removeNewlinesFormatter = new RemoveNewlinesFormatter();
             for (String key : bibEntry.getFieldMap().keySet()) {
-                if (FieldName.MONTH.equals(key)) {
-                    bibEntry.getFieldMap().put(FieldName.MONTH, bibEntry.getMonth().get().getShortName());
-                }
-
                 bibEntry.getField(key)
                         .map(removeNewlinesFormatter::format)
                         .map(latexToHtmlConverter::format)
-                        .ifPresent(value -> bibTeXEntry.addField(new Key(key), new DigitStringValue(value)));
+                        .ifPresent(value -> {
+                            if((FieldName.MONTH.equals(key))){
+                                value = bibEntry.getMonth().get().getShortName();
+                            }
+                            bibTeXEntry.addField(new Key(key), new DigitStringValue(value));
+                        });
             }
             return BIBTEX_CONVERTER.toItemData(bibTeXEntry);
         }