Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEEE preview does not display month #3239

Closed
fylimas opened this issue Sep 28, 2017 · 8 comments
Closed

IEEE preview does not display month #3239

fylimas opened this issue Sep 28, 2017 · 8 comments
Labels
entry-preview good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@fylimas
Copy link

fylimas commented Sep 28, 2017

Currently, the reference are previewed in Jabref without the field month, as shown in the following:
image

However, the bib should be and is compiled correctly as follows (in which the month is displayed):
image

This is consistent as the ieee.csl fromcitationstyles.org
image

That is to say, jabref handles the field month correctly, but the preview with ieee.csl lack the display of field month.
I think this is an error and should be fixed.

Thanks guys for the great jobs.

@vatdaell
Copy link

vatdaell commented Oct 1, 2017

I can look into this and try to fix it

@tokkot
Copy link
Contributor

tokkot commented Oct 24, 2017

I looked into this some, but got stuck. If the month is a literal string "{january}", the preview prints correctly. So, I think there is a problem with how the month field is getting passed to citeproc-java. Which in turn, is maybe a problem with how the BibTeXEntry object is getting built by JabRef. But I'm really not sure if that is a bug in citeproc-java or in JabRef.

@Siedlerchr
Copy link
Member

@tokkot Thanks for your analysis! Maybe you could debug through it and see where the problem lies?
I took a quick look and it seems that the conversion is done outside of JabRef in the citeproc java:
Maybe you can have a look here and an at the DateParser in detail
https://github.com/michel-kraemer/citeproc-java/blob/b60592f4e02876fc06dde233e17b8411a6703408/citeproc-java/src/main/java/de/undercouch/citeproc/bibtex/BibTeXConverter.java#L223

@koppor
Copy link
Member

koppor commented Dec 20, 2017

Coming from the linked issue:

Possibly, our data model needs to be improved. Currently had a "hack" to be able to store

month = mar

When entering mar in the entry editor, JabRef saves it to

month = {mar}

How to produce the other result? JabRef offers to enter #mar# in the entry editor. Then, the field content is saved without #. See also http://help.jabref.org/en/EntryEditor#field-consistency-checking

@Siedlerchr
Copy link
Member

Is probably a similar issue as #3539, modifying the StringConverter should do the job

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 4, 2018
DevSiroukane pushed a commit to DevSiroukane/jabref that referenced this issue Apr 26, 2018
On month change from comboBox on OptionalFieldsTab:
1. Month was not appear on IEEE style.
2. Month was not written correctly on SourceTab.
both issues get fixed.
@DevSiroukane
Copy link
Contributor

Guys,
I just fix both issues Month preview on IEEE style.
Also, on SourceTab.

Check my last commit here on my repository that I fork.
My suggested solution

@Siedlerchr
Copy link
Member

@DevSiroukane Yeah, cool! Please open a Pull Request. Go to https://github.com/JabRef/jabref/pulls
and create a new Pull Request, on the left you select master and on the right your branch

DevSiroukane pushed a commit to DevSiroukane/jabref that referenced this issue Apr 26, 2018
On month change from comboBox on OptionalFieldsTab:
1. Month was not appear on IEEE style.
2. Month was not written correctly on SourceTab.
both issues get fixed.
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue Apr 26, 2018
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue Apr 26, 2018
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue Apr 26, 2018
Wrong order for 'org.jabref.model.entry.FieldName' import.
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue Apr 28, 2018
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue Apr 28, 2018
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue Apr 29, 2018
Make change direct on bibTeXEntry instead of creating a copy of bibEntry
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue Apr 30, 2018
DevSiroukane added a commit to DevSiroukane/jabref that referenced this issue May 1, 2018
tobiasdiez pushed a commit that referenced this issue May 2, 2018
* Fix IEEE preview does not display month (#3239)

On month change from comboBox on OptionalFieldsTab:
1. Month was not appear on IEEE style.
2. Month was not written correctly on SourceTab.
both issues get fixed.

* Fix IEEE preview does not display month (#3239)

#3983 (comment)

* Fix IEEE preview does not display month (#3239)

#3983 (comment)

* Fix IEEE preview does not display month (#3239)

Wrong order for 'org.jabref.model.entry.FieldName' import.

* Fix IEEE preview does not display month (#3239)

fix missing check style issue

* Fix IEEE preview does not display month (#3239)

Remove Superfluous Comments
#3983 (comment)

* Fix IEEE preview does not display month (#3239)

Make change direct on bibTeXEntry instead of creating a copy of bibEntry

* Fix IEEE preview does not display month (#3239)

fix check style issue

* Fix IEEE preview does not display month (#3239)

#3983 (comment)
@tobiasdiez
Copy link
Member

tobiasdiez commented May 2, 2018

This is now fixed in the maintable-beta branch thanks to @DevSiroukane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entry-preview good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
None yet
Development

No branches or pull requests

9 participants