Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hex converter toys #86

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Added hex converter toys #86

merged 4 commits into from
Nov 29, 2021

Conversation

btiteux
Copy link
Collaborator

@btiteux btiteux commented Nov 29, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys doesn't have a tool to convert number between different base.

Issue Number: #18

What is the new behavior?

  • Added a tool that allow the user to convert number between different base.

image

image

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@btiteux btiteux requested a review from veler November 29, 2021 08:46
@veler veler linked an issue Nov 29, 2021 that may be closed by this pull request
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall :) Thank you so much! :D

src/dev/impl/DevToys/Core/Formatter/BaseNumberFormatter.cs Outdated Show resolved Hide resolved
src/dev/impl/DevToys/DevToys.csproj Outdated Show resolved Hide resolved
src/dev/impl/DevToys/DevToys.csproj Show resolved Hide resolved
src/dev/impl/DevToys/Strings/cs-CZ/HexConverter.resw Outdated Show resolved Hide resolved

public bool CanBeTreatedByTool(string data)
{
return false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could detect binaries and hexadecimal automatically. I can't think of any other tool where binaries and hex would be pasted, so perhaps it would be cool to be able to leverage Smart Detection in these scenario.

@btiteux btiteux merged commit f6fb37e into main Nov 29, 2021
@btiteux btiteux deleted the toys/hex-converter branch November 29, 2021 19:32
veler pushed a commit that referenced this pull request Mar 31, 2023
* Added hexconverter toy

* added french localization and Accessibility name

* renamed HexConverter to NumberBaseConverter

* cleaned csproj *.resw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hex converter
2 participants