Added hex converter toys #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
veler
approved these changes
Nov 29, 2021
|
|
||
| public bool CanBeTreatedByTool(string data) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
I'm wondering if we could detect binaries and hexadecimal automatically. I can't think of any other tool where binaries and hex would be pasted, so perhaps it would be cool to be able to leverage Smart Detection in these scenario.
src/dev/impl/DevToys/ViewModels/Tools/HexConverter/HexConverterToolViewModel.cs
Outdated
Show resolved
Hide resolved
veler
reviewed
Nov 29, 2021
veler
approved these changes
Nov 29, 2021
veler
pushed a commit
that referenced
this pull request
Mar 31, 2023
* Added hexconverter toy * added french localization and Accessibility name * renamed HexConverter to NumberBaseConverter * cleaned csproj *.resw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
DevToys doesn't have a tool to convert number between different base.
Issue Number: #18
What is the new behavior?
Other information
Quality check
Before creating this PR, have you: