-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement i18n #37 #50
Conversation
@kasthor is attempting to deploy a commit to the Developerdao Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/developdao/dao-job-board/ahQDtmGhgbDeLJrK4W4ij6XZgTSy [Deployment for 0e6a705 failed] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasthor there's a TypeScript error popping up during the build. Can you have a look at the Github workflow logs? (or you can just run yarn build
locally)
client/public/locales/en/common.json
Outdated
"sign_up": "Sign Up" | ||
}, | ||
"landing": { | ||
"looking_for_talent": "Looking for Web3 Talent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the ?
from the original string 🙂
"search_devs": "Search Devs", | ||
"post_job": "Post Job", | ||
"post_gig": "Post Gig", | ||
"search_gig": "Search Gig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the s
from the original string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah should be "search_gigs": "Search Gigs"
instead of it being singular since we'd be doing a text full search
client/public/locales/en/common.json
Outdated
}, | ||
"landing": { | ||
"looking_for_talent": "Looking for Web3 Talent", | ||
"looking_for_work": "Looking for Web3 Work", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the ? from the original string 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to stop nit-picking the actual strings, b/c idk if they're actually supposed to be updated to what you put. Keep it in 🧠 though before it's merged
🤙
Hello @kasthor would love to get the merge conflicts resolved before anything else |
GM! Hi @Dhaiwat10 Thanks for your feedback on this, i didn't did the build previously, but now it works also thanks @frankTurtle for your observations on this, made the corrections for this new PR Let me know how this looks so it opens the posibility to add new strings wagmi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor change request, just to add an s
@kasthor
Other than that it looks pretty neat 👍
"search_devs": "Search Devs", | ||
"post_job": "Post Job", | ||
"post_gig": "Post Gig", | ||
"search_gig": "Search Gig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah should be "search_gigs": "Search Gigs"
instead of it being singular since we'd be doing a text full search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet as pie 🥧 thanks man for the initiative and integrating this! @kasthor
This is the base implementation for next-i18next
Currently I have made only translation keys for the landing page, but now we can begin to use this implementation on new features
Closes #37