This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fixed StochRSI calculations #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
approved these changes
Jan 22, 2018
DeviaVir
pushed a commit
that referenced
this pull request
Jan 22, 2018
* Add trend_bollinger * Add wavetrend strategy * Add StdDev * Add Momentum Strategy * Fixed StochRSI calculations (#1196) * Fix SRSI calculation * Added test case for SRSI. Switched RSI and SRSI output to float and adjusted display accordingly * Oops, disabled all other tests by mistake * Fix test assertion * Fix cexio update-products.sh (#1194) This fixes the error `/usr/bin/env: ‘node\r’: No such file or directory` * Enhance display of High/Low bollinger values Report is now able to display values less than 1. space limited to 7 characters per column so smallest value is 0.00001
aquamanjl
added a commit
to aquamanjl/zenbot
that referenced
this pull request
Jan 22, 2018
* Fix SRSI calculation * Added test case for SRSI. Switched RSI and SRSI output to float and adjusted display accordingly * Oops, disabled all other tests by mistake * Fix test assertion
aquamanjl
pushed a commit
to aquamanjl/zenbot
that referenced
this pull request
Jan 22, 2018
* Add trend_bollinger * Add wavetrend strategy * Add StdDev * Add Momentum Strategy * Fixed StochRSI calculations (DeviaVir#1196) * Fix SRSI calculation * Added test case for SRSI. Switched RSI and SRSI output to float and adjusted display accordingly * Oops, disabled all other tests by mistake * Fix test assertion * Fix cexio update-products.sh (DeviaVir#1194) This fixes the error `/usr/bin/env: ‘node\r’: No such file or directory` * Enhance display of High/Low bollinger values Report is now able to display values less than 1. space limited to 7 characters per column so smallest value is 0.00001
DeviaVir
pushed a commit
that referenced
this pull request
Jan 23, 2018
…f XX.X format forced to XX.XX (#1205) * Add trend_bollinger * Add wavetrend strategy * Add StdDev * Add Momentum Strategy * Fixed StochRSI calculations (#1196) * Fix SRSI calculation * Added test case for SRSI. Switched RSI and SRSI output to float and adjusted display accordingly * Oops, disabled all other tests by mistake * Fix test assertion * Fix cexio update-products.sh (#1194) This fixes the error `/usr/bin/env: ‘node\r’: No such file or directory` * Adjust display for RSI being changed to float RSI formated correctly.
Closed
DeviaVir
pushed a commit
that referenced
this pull request
Jan 24, 2018
* Add trend_bollinger * Add wavetrend strategy * Add StdDev * Add Momentum Strategy * Save options to file if backtester_generation has value This is to improve reliability of passing information to backtested scripts. * Fixed StochRSI calculations (#1196) * Fix SRSI calculation * Added test case for SRSI. Switched RSI and SRSI output to float and adjusted display accordingly * Oops, disabled all other tests by mistake * Fix test assertion * Fix cexio update-products.sh (#1194) This fixes the error `/usr/bin/env: ‘node\r’: No such file or directory` * Sim result passed as file instead of being scraped * Cleanup code and comments * Ignore the sim outputs * Correct mistake in vsBuyHold Missed return result of vsBuyHold in the Sim command JSON results. vsBuyHold needs to be a percentage represented by whole numbers. i.e. 99.5 instead of 0.995. * Alter auto_backtester to use json output changed json file name to new format sim_<selector>_<marketExchangePair>_<generation>.json if selector or marketExcahngePair contains ‘_’ it will be stripped this allows for easier parsing of the file name. Final additions or I’ll just keep tweaking it. * Remove debug code now matches genetic_backtester.
DeviaVir
pushed a commit
that referenced
this pull request
Jan 24, 2018
* Add trend_bollinger * Add wavetrend strategy * Add StdDev * Add Momentum Strategy * Fixed StochRSI calculations (#1196) * Fix SRSI calculation * Added test case for SRSI. Switched RSI and SRSI output to float and adjusted display accordingly * Oops, disabled all other tests by mistake * Fix test assertion * Fix cexio update-products.sh (#1194) This fixes the error `/usr/bin/env: ‘node\r’: No such file or directory` * Enhance display of High/Low bollinger values Report is now able to display values less than 1. space limited to 7 characters per column so smallest value is 0.00001 * Fix Bittrex exchange error handling Updated bittrex api from node.bittrex.api -> node-bittrex-api node.bittrex.api is no longer maintained Added some error handling so exchange is now passing back useful errors to the engine. i.e. it will no longer keep retrying a buy sell order if there isn’t enough funds. socket errors no longer crash the system but passed to the retry handler. * Correct formatting * Cleanup remove white space, a debug property, and extra lines.
This was referenced Apr 13, 2021
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes in this PR include
Fix the calculations for Stochstic RSI module
Convert RSI and SRSI output to floats to better match expected values
Test case for SRSI