Update search tests and lintings #40
Conversation
| @@ -6,6 +6,7 @@ import { | |||
| ERR_MODULE_NOT_FOUND, | |||
| ERR_MODULE_DISABLED, | |||
| ERR_MODULE_REMOVE_FAILED, | |||
| ERR_MODULE_SEARCH_FAILED, | |||
There was a problem hiding this comment.
This one still need to be added to 'errors/index.js'
There was a problem hiding this comment.
Woops, looks like I left that out as well! Will get to this piece tonight otherwise feel free to send a quick PR. 👍
| const results = packages.map(pkg => pkg.name[0]); | ||
| resolve(results); | ||
| } else { | ||
| if (!Array.isArray(packages) || !packages.length) { |
There was a problem hiding this comment.
If no packages are found for the search it will result in a reject (and an error in the cli) (because of !packages.length) and maybe you just want to reject if the search actually fails.
| * @param {String} q - The keyword to search | ||
| * @return {String} | ||
| */ | ||
| const getSearchUrl = q => `https://npmsearch.com/query?q=${q}%20AND%20(keywords:dext-theme%20OR%20keywords:dext-plugin)&fields=name,description`; |
There was a problem hiding this comment.
This doesn't work on my machine for some reason...
Error: Protocol "https:" not supported. Expected "http:"
at new ClientRequest (_http_client.js:55:11)
at Object.exports.request (http.js:31:10)
at Object.exports.get (http.js:35:21)
at Promise (/Users/wolfwood/dev/dext-cli/node_modules/dext-core-utils/src/utils/search.js:23:15)
at searchPackages (/Users/wolfwood/dev/dext-cli/node_modules/dext-core-utils/src/utils/search.js:19:29)
at Promise (/Users/wolfwood/dev/dext-cli/node_modules/dext-core-utils/src/api/index.js:29:3)
at Object.search (/Users/wolfwood/dev/dext-cli/node_modules/dext-core-utils/src/api/index.js:28:30)
at Args.args.command (/Users/wolfwood/dev/dext-cli/cli.js:12:14)
at Args.runCommand (/Users/wolfwood/dev/dext-cli/node_modules/args/dist/index.js:327:37)
at Args.parse (/Users/wolfwood/dev/dext-cli/node_modules/args/dist/index.js:429:12)There was a problem hiding this comment.
Ah! This is my fault. I've updated the endpoint to the secure protocol. We'll just need to require the https module instead of http. Feel free to send a new PR for this. 👍
This extends on @W0lfw00d's awesome search PR that was just merged.