Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return intent #182

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Return intent #182

merged 1 commit into from
Apr 25, 2021

Conversation

tobiasKaminsky
Copy link
Contributor

πŸš€ Description

Our ButterknifeController needs to startActivityForResult, and not by passed activity.
So getting the Intent and then starting it "manually" would fix our use case.

πŸ“„ Motivation and Context

See above: to have more flexibility when using lib

πŸ§ͺ How Has This Been Tested?

Run startActivityForResult "manually" in calling class.

πŸ“· Screenshots (if appropriate)

/

πŸ“¦ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@tobiasKaminsky tobiasKaminsky mentioned this pull request Mar 29, 2021
6 tasks
@Dhaval2404 Dhaval2404 merged commit 371b84f into Dhaval2404:master Apr 25, 2021
@Dhaval2404
Copy link
Owner

Thank you @tobiasKaminsky

@Dhaval2404 Dhaval2404 mentioned this pull request May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants