Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILE as Provider #184

Closed
wants to merge 2 commits into from
Closed

Conversation

tobiasKaminsky
Copy link
Contributor

πŸš€ Description

Add FILE as provider to directly supply a local file for cropping.

πŸ“„ Motivation and Context

E.g. let user browse through pre-defined assets or custom gallery showing remote images.
If user clicks on such an image app downloads asset in background and can now directly show crop.

πŸ§ͺ How Has This Been Tested?

  • create an image file
  • point to it via File
  • needs Return intentΒ #182
  • intent.putExtra(ImagePicker.EXTRA_FILE, file);

πŸ“· Screenshots (if appropriate)

/

πŸ“¦ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@tobiasKaminsky
Copy link
Contributor Author

Remaining question is if this should be handled via ".setFile()" or if this approach via intent is ok?

@Dhaval2404
Copy link
Owner

@tobiasKaminsky Thank you for your contribution. It will be easier to use any crop library to just perform the crop operations. This will help keep the library clean for unnecessary dependencies.

Also, As of now ImagePicker only supports uCrop. If 3rd party library is used directly then the developer will have better control over its customization.

I appreciate your time and efforts in adding this feature. I hope this will not discourage you from further contribution.

@Dhaval2404 Dhaval2404 closed this Apr 25, 2021
@tobiasKaminsky
Copy link
Contributor Author

Thanks for your feedback @Dhaval2404
My motivation was to only have once library, but I understand it from your point :)

@timkrueger timkrueger deleted the file branch November 17, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants