Quick makeover to restore package functionality.

[MarcoZanon]

Thank you for creating and sharing this bot. I applied some crude fixes to address the error message:

error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version

They will require for sure some optimization, but they are good enough to execute GET, POST and DELETE commands properly via httr .

I could not test them with macOS, so anything related to mac OS is still unchanged.

They may be too messy for a pull request, but I wanted to submit them to your consideration.

[DheerajAgarwal]

Thanks. I will test it on macos and try to push this to Cran.

On Mon, 15 Feb 2021 at 8:43 am, Marco Zanon ***@***.***> wrote: Thank you for creating and sharing this bot. I applied some crude fixes to address the error message: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version They will require for sure some optimization, but they are good enough to execute GET, POST and DELETE commands properly via httr . I could not test them with macOS, so anything related to mac OS is still unchanged. ------------------------------ You can view, comment on, or merge this pull request online at: #14 Commit Summary - Quick makeover to restore package functionality. File Changes - *M* R/accounts.R <https://github.com/DheerajAgarwal/rgdax/pull/14/files#diff-facf144f276f8f97b7277dfcd88de1f61417f68f2c86ae57292e14103179a289> (12) - *M* R/add_order.R <https://github.com/DheerajAgarwal/rgdax/pull/14/files#diff-37073c1d0f2fecad4b1ae2d019398d4c2ab883e088e72f93f292997763f9d3c4> (18) - *M* R/auth.R <https://github.com/DheerajAgarwal/rgdax/pull/14/files#diff-0edd28f1a8f03b764157c6cd2fe3050816caceaf04c5b39553634936bb973b58> (49) Patch Links: - https://github.com/DheerajAgarwal/rgdax/pull/14.patch - https://github.com/DheerajAgarwal/rgdax/pull/14.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#14>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADDD4APAMEGK3DPMW4REZGTS7A7XFANCNFSM4XTUFQPQ> .

-- Dheeraj Agarwal Sent from my iPhone

[svdijkman]

I tested this patch, but got a message that just said "BadRequest" as a return of the account() function. Not sure if it's my fault, as I have not yet used this package before, so could've made a mistake.

[MarcoZanon]

I tested this patch, but got a message that just said "BadRequest" as a return of the account() function. Not sure if it's my fault, as I have not yet used this package before, so could've made a mistake.

The account() function likely still needs fixing. To be fair, I did not test it. I modified only the accounts() function. I confirm that the fix still works for me.

[DheerajAgarwal]

I have fixed issues with the auth functions and any dependent functions on auth should work fine on windows. macos is still under fixes. Thanks for your contribution.

[MarcoZanon]

Excellent! Keep up the good work!