Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic merge of develop into master #499

Merged
merged 78 commits into from
Sep 6, 2018
Merged

Periodic merge of develop into master #499

merged 78 commits into from
Sep 6, 2018

Conversation

AdriaanRol
Copy link
Contributor

Periodic merge.
Reasons to merge

  • Upcoming update to OpenQL v0.5.3
  • Fix broken test related to CZ simulation on master.

Requesting @elrama- to review as he is not currently working on develop.

fbattistel and others added 30 commits August 2, 2018 15:56
Prepared function multipath_filter2 for new firmware release. The default value for the argument ppl now corresponds to the new number of pipeline stages (2) of the hardware filter that will be deployed to the QuSurf customers.
…CarloLab-Delft/PycQED_py3 into develop_awgv1_devices"

This reverts commit 066b3c3, reversing
changes made to 31ee0be.
…ant for qubit and bus resonator to dac scans
with geralization to recognize awg channels used to do mw pulses
@slavoutich
Copy link
Contributor

As a comment: you use sometimes '''docstring''', while PEPs specify double brackets ("""docstring"""). This might confuse some code editors, I guess.

@AdriaanRol
Copy link
Contributor Author

@slavoutich , thanks for pointing that out. I'll use double brackets from now on.

@AdriaanRol
Copy link
Contributor Author

@elrama- , gentle reminder

@elrama-
Copy link
Contributor

elrama- commented Sep 5, 2018

I have been checking it, but still not finished on my check-up. Will give an update in a day.

@AdriaanRol
Copy link
Contributor Author

@elrama- , thanks for the update

Copy link
Contributor

@elrama- elrama- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright. Only codacy complaining

@AdriaanRol AdriaanRol merged commit 4d5591c into master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants