Compatibility fix for VirtualBox #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmap is not useable with MAP_SHARED under VirtualBox. Moved to a simple malloc, modify, write & free approach for the flash buffer
Added explicit cast to flash from malloc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmap with option MAP_SHARED will cause (void *)-1 with errno = invalid argument error returned and furthermore cause a segmentation fault.
Refer https://www.virtualbox.org/ticket/819
This can be reproduced using the espressif VM image under VirtualBox.
I replaced the mmap with a malloc and a later write back + free.