Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-29133 - 'Enable start of new pipeline build' does not work with parameterized trigger #137

Merged
merged 3 commits into from Jul 28, 2015

Conversation

@dawidmalina
Copy link
Contributor

dawidmalina commented Jul 22, 2015

No description provided.

@dawidmalina

This comment has been minimized.

Copy link
Contributor Author

dawidmalina commented Jul 22, 2015

Looks like test coverage stucked.

@patbos

This comment has been minimized.

Copy link
Member

patbos commented Jul 22, 2015

@dawidmalina No problem, it might take up to several hours before the coverage from Coveralls to be reported.

@dawidmalina

This comment has been minimized.

Copy link
Contributor Author

dawidmalina commented Jul 27, 2015

@patbos What do you think about this change?

@patbos

This comment has been minimized.

Copy link
Member

patbos commented Jul 27, 2015

Great job! Would be nice to have a integration test of it since it is hard to cover by unit test.

…th parameterized trigger
@dawidmalina

This comment has been minimized.

Copy link
Contributor Author

dawidmalina commented Jul 28, 2015

@patbos - done

patbos added a commit that referenced this pull request Jul 28, 2015
JENKINS-29133 - 'Enable start of new pipeline build' does not work with parameterized trigger
@patbos patbos merged commit 6d9dc0b into Diabol:master Jul 28, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 99.232%
Details
@patbos

This comment has been minimized.

Copy link
Member

patbos commented Jul 28, 2015

Great work!

@dawidmalina dawidmalina deleted the dawidmalina:parameterized-job branch Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.