JENKINS-25457 Server error when viewing pipeline with NOT_BUILT result

src/main/java/se/diabol/jenkins/pipeline/domain/status/SimpleStatus.java

@@ -102,6 +102,12 @@ public boolean isCancelled() {
         return CANCELLED.equals(type);
     }
 
+    @Override
+    public boolean isNotBuilt() {
+        return NOT_BUILT.equals(type);
+    }
+
+
     @Override
     public boolean isDisabled() {
         return DISABLED.equals(type);
@@ -140,9 +146,11 @@ public static Status resolveStatus(AbstractProject project, AbstractBuild build,
         }
         if (Result.UNSTABLE.equals(result)) {
             return StatusFactory.unstable(build.getTimeInMillis(), build.getDuration());
-        } else {
-            throw new IllegalStateException("Result " + result + " not recognized.");
         }
+        if (Result.NOT_BUILT.equals(result)) {
+            return StatusFactory.notBuilt(build.getTimeInMillis(), build.getDuration());
+        }
+        throw new IllegalStateException("Result " + result + " not recognized.");
     }
 
 

src/main/java/se/diabol/jenkins/pipeline/domain/status/Status.java

@@ -40,6 +40,8 @@ public interface Status {
 
     boolean isDisabled();
 
+    boolean isNotBuilt();
+
     long getLastActivity();
 
     String getTimestamp();

src/main/java/se/diabol/jenkins/pipeline/domain/status/StatusFactory.java

@@ -49,6 +49,9 @@ public static Status unstable(long lastActivity, long duration) {
     public static Status cancelled(long lastActivity, long duration) {
         return new SimpleStatus(StatusType.CANCELLED, lastActivity, duration);
     }
+    public static Status notBuilt(long lastActivity, long duration) {
+        return new SimpleStatus(StatusType.NOT_BUILT, lastActivity, duration);
+    }
 
     public static Status disabled() {
         return new SimpleStatus(StatusType.DISABLED, -1, -1);

src/main/java/se/diabol/jenkins/pipeline/domain/status/StatusType.java

@@ -18,5 +18,5 @@
 package se.diabol.jenkins.pipeline.domain.status;
 
 public enum StatusType {
-    IDLE, RUNNING, QUEUED, SUCCESS, UNSTABLE, FAILED, CANCELLED, DISABLED
+    IDLE, RUNNING, QUEUED, SUCCESS, UNSTABLE, FAILED, CANCELLED, DISABLED, NOT_BUILT
 }

src/main/webapp/pipeline-common.css

@@ -219,6 +219,13 @@ div.task-progress-running {
     font-weight: bold;
 }
 
+.NOT_BUILT {
+    border-left: 6px solid #8b8989;
+    background-color: #d3d3d3;
+    font-weight: bold;
+}
+
+
 .DISABLED {
     border-left: 6px solid transparent;
     color: #a9a9a9;

src/main/webapp/pipeline-fullscreen.css

@@ -107,6 +107,12 @@ div.task-progress {
     background-color: inherit;
 }
 
+.NOT_BUILT {
+    border-left: 6px solid #8b8989;
+    font-weight: bold;
+    background-color: inherit;
+}
+
 .DISABLED {
     border-left: 6px solid transparent;
     color: #a9a9a9;

src/test/java/se/diabol/jenkins/pipeline/domain/status/SimpleStatusTest.java

@@ -39,7 +39,6 @@
 import java.util.List;
 
 import static org.junit.Assert.*;
-import static org.junit.Assert.assertEquals;
 
 @RunWith(MockitoJUnitRunner.class)
 public class SimpleStatusTest {
@@ -118,7 +117,6 @@ public void testResolveStatusUnstable() throws Exception {
     }
 
 
-
     @Test
     public void testResolveStatusAborted() throws Exception {
         FreeStyleProject project = jenkins.createFreeStyleProject();
@@ -136,16 +134,17 @@ public void testResolveStatusAborted() throws Exception {
 
     @Test
     public void testResolveStatusNotBuilt() throws Exception {
-        //Result.NOT_BUILT should never occur for a build, just for a module within a maven build.
         FreeStyleProject project = jenkins.createFreeStyleProject();
         project.getBuildersList().add(new MockBuilder(Result.NOT_BUILT));
         project.scheduleBuild2(0);
         jenkins.waitUntilNoActivity();
-        try {
-            SimpleStatus.resolveStatus(project, project.getLastBuild(), null);
-            fail("Should throw exception here");
-        } catch (IllegalStateException e) {
-        }
+        Status status = SimpleStatus.resolveStatus(project, project.getLastBuild(), null);
+        assertTrue(status.isNotBuilt());
+        assertEquals("NOT_BUILT", status.toString());
+        assertEquals(project.getLastBuild().getTimeInMillis(), status.getLastActivity());
+        assertEquals(project.getLastBuild().getDuration(), status.getDuration());
+        assertNotNull(status.getTimestamp());
+        assertTrue(status.getType().equals(StatusType.NOT_BUILT));
     }
 
 

src/test/java/se/diabol/jenkins/pipeline/domain/status/StatusTypeTest.java

@@ -35,13 +35,14 @@ public void testValueOf() {
         assertEquals(StatusType.RUNNING, StatusType.valueOf("RUNNING"));
         assertEquals(StatusType.SUCCESS, StatusType.valueOf("SUCCESS"));
         assertEquals(StatusType.UNSTABLE, StatusType.valueOf("UNSTABLE"));
+        assertEquals(StatusType.NOT_BUILT, StatusType.valueOf("NOT_BUILT"));
     }
 
     @Test
     public void testValue() {
         StatusType[] values = StatusType.values();
         assertNotNull(values);
-        assertEquals(8, values.length);
+        assertEquals(9, values.length);
     }
 
 }