Implement grouping of Attributes on generated UIs #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 45.19% 43.79% -1.40%
==========================================
Files 17 17
Lines 624 653 +29
==========================================
+ Hits 282 286 +4
- Misses 342 367 +25 ☔ View full report in Codecov by Sentry. |
MJGaughran
reviewed
Jan 23, 2024
Attributes and Methods take an optional group to be placed in. If group is unset it will appear at the root of the UI. SubControllers are displayed on a SubScreen of the parent Controller. Update to use pvi DLSFormatter class directly rather than relying on yaml file.
There are ongoing breaking changes to pvi, so pin to minor version. Bugfix version bumps are OK.
MJGaughran
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MJGaughran I will leave this open and merge it when I next start on another set of changes. If you get a chance to look at it that would be great. No worries if not.
The accompanying change to the demo may help.
With grouping the generated UI looks like this: