Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1302 - add visit to container even if UAS fails #762

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1302

Summary:

UAS often fails to find sessions it has created in the last few minutes, so when loading the second UDC puck from a shipment, Synchweb doesnt assign the session id to the container, even though it knows the session id and so it must exist.

Changes:

  • Treat a 404 error the same as a success
  • Only log errors from UAS, not only successes (UAS.php line 76)
  • Fix indentation to use spaces not tabs

To test:

  • Hard to test without UAS. Currently UAS has a workaround in so it doesn't return a 404, but that will probably be removed soon.
  • I suggest (if approved and if UAS take out their workaround) we roll out to staging, then point the beamline to staging temporarily. We can load multiple pucks from one shipment, which should assign the session id, but will log the error from UAS.

@ndg63276 ndg63276 changed the title Fix/lims 1302/add visit to container even if uas fails LIMS-1302 - add visit to container even if UAS fails Apr 25, 2024
@ndg63276 ndg63276 changed the base branch from prerelease to master June 24, 2024 09:35
@NKatti2011 NKatti2011 self-assigned this Jul 26, 2024
@NKatti2011 NKatti2011 self-requested a review July 26, 2024 10:45
@NKatti2011
Copy link
Collaborator

Ready to Release (but should test on staging first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants