Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-700: Allow bulk editing of protein #808

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-700
JIRA ticket: LIMS-691
Github issue: #552

Summary:

Improve the behaviour of the bulk editor.

Changes:

  • Disable the bulk editor dropdown, textbox and submit button until the previous request has finished
  • Shorten the debounce time on updating the samples to make the form respond quicker
  • Add (green only) protein acronym to the fields that can be bulk edited
  • Sort the fields alphabetically by name rather than "field name"
  • Correct the message displayed when samples are updated successfully
  • Add an error notification if samples are not updated

To test:

  • Make a new puck with some samples in, save it, and then view it
  • Check the bulk editor appears with the dropdown in alphabetical order (ie Barcode before Cell A)
  • Select Comment and type a new comment, check it appears promptly next to each sample
  • Open the dev tools, click the Update Samples button a few times, check only one PUT request is sent
  • Select Protein Acronym, choose a new acronym, click Update Samples, then refresh the page to check the change has persisted
  • Check the success message appears and says "Sample(s) have been successfully updated"
  • Choose "Screening Method", then select "Better Than", but dont choose a minimum resolution. Click Update Samples, and check a notification appears at the top to say there was an error, and validation messages appear at the bottom.
  • Go to proposal mx31800, find a container to bulk edit (or make a new one), choose Protein Acronym, check that Diazocine does not appear in the list as it is a YELLOW sample
  • Go to a container that has had data collected on it, check the bulk editor is hidden

@ndg63276 ndg63276 requested a review from gfrn July 24, 2024 10:47
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R4.1 August 16, 2024 12:45
@ndg63276 ndg63276 merged commit 35cff7d into pre-release/2024-R4.1 Aug 16, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-700/allow-bulk-editing-of-protein branch August 27, 2024 09:25
ndg63276 added a commit that referenced this pull request Sep 3, 2024
* LIMS-1355: Make OAuth2 support more generic (#792)

* LIMS-1383, LIMS-160, LIMS-269: Improve reprocessing (#812)

* LIMS-1379: Grid scan heatmaps are not snaked correctly (#800)

* LIMS-1119: Show text on small buttons (#798)

* LIMS-700: Allow bulk editing of protein (#808)

* LIMS-1371, LIMS-1372: Add search and 'My Groups' to Sample Groups page (#579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants