-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot run plans without a message bus (client) #427
Comments
As it turns out I was misremembering. So will accept the CLI raising early if it can't connect to the bus |
The use of message bus is guarded and there are tests added to check this for the CLI . |
ZohebShaikh
added a commit
that referenced
this issue
Apr 26, 2024
ZohebShaikh
added a commit
that referenced
this issue
May 7, 2024
callumforrester
pushed a commit
to DiamondLightSource/bluesky-stomp
that referenced
this issue
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Relates to #426, the blueapi CLI listens to updates from the server via the message bus so it throws an error if you try to use blueapi without a bus being present.
To Reproduce
Terminal 1
# start blueapi server blueapi serve
Terminal 2
Possible solution
The CLI does have a message bus-free mode that can be enabled with a flag, we should also enable it if the connection fails and print a warning to the user. In this case the CLI does not block until the plan completes but expects the user to run further commands to poll the server. The warning message should make this clear.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: