make worker queue have a size of 1 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would write tests for this, but we need #145 to be merged before we can do that. So I think this should be a WIP until that is done. |
rosesyrett
changed the title
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 82.95% 83.07% +0.12%
==========================================
Files 39 40 +1
Lines 1103 1111 +8
==========================================
+ Hits 915 923 +8
Misses 188 188
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
solves #157 |
added 2 commits
May 3, 2023 10:03
|
there's a lot more changes in this than there ought to be... investigating now. |
rosesyrett
force-pushed
the
one-task-on-queue
branch
from
239da6d
to
e82f4d4
Compare
rosesyrett
changed the title
tests/worker/test_reworker.py
Outdated
| @@ -125,3 +126,12 @@ def on_event(event: E, event_id: Optional[str]) -> None: | |||
| sub = stream.subscribe(on_event) | |||
| future.add_done_callback(lambda _: stream.unsubscribe(sub)) | |||
| return future | |||
|
|
|||
|
|
|||
| def test_worker_only_accepts_one_task_on_queue(worker: Worker, timeout: float = 5.0): | |||
callumforrester
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made queue have one thing in it. Raising error if attempt to submit while worker is running