Add try except to messaging connection #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 87.14% 87.17% +0.02%
==========================================
Files 42 42
Lines 1642 1645 +3
==========================================
+ Hits 1431 1434 +3
Misses 211 211 ☔ View full report in Codecov by Sentry. |
DiamondJoseph
approved these changes
Jan 9, 2024
ZohebShaikh
pushed a commit
that referenced
this pull request
May 7, 2024
Just a try except around the connection attempt. It displays the failure to connect in the logs but does not fail fast. It allows the rest of the application setup to complete just without a connection to a message bus. You can then `crtl+c` to close it. I was advised to just add this fix until the subprocess work is done then we can re-address the behaviour we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #220 (after a fashion).
This is just a try except around the connection attempt. It displays the failure to connect in the logs but does not fail fast. It allows the rest of the application setup to complete just without a connection to a message bus. You can then
crtl+cto close it.I would have preferred to fail fast if we are demanding the presence of a message bus, however trying to address exceptions in the fastapi
lifespancaused things to hang. The I was advised to just add this crude fix until the subprocess work is done then we can re-address the behaviour we want for each of these cases.