Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skeleton #52

Merged
merged 73 commits into from
May 22, 2023
Merged

Update skeleton #52

merged 73 commits into from
May 22, 2023

Conversation

aawdls
Copy link
Contributor

@aawdls aawdls commented May 3, 2023

Apply the latest skeleton repo.

Ditch changes to the docs as current build is fine.

coretl and others added 30 commits September 2, 2022 09:17
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [black](https://github.com/psf/black) from 22.6.0 to 22.8.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@22.6.0...22.8.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
There are now developer and user guides. The version switcher is native
to the theme so added a script to generate it.
This saves another runner starting up just for this
Fixing a bug that occurs when releasing. (This is already fixed in the skeleton-cli project but failed to get copied to skeleton).
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Pin pydata-sphinx-theme to allow the build to complete
pydata/pydata-sphinx-theme#987
Use the official Python Packaging Authority (PyPA) Action to publish to PyPI
Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@22.8.0...22.10.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Translate punctuation and unicode in branch names to _
- Environment variable no longer needs to be set
- All commands run with tox-direct by default
- All environment variables passed through
- Moved wheel and sdist creation to the dist job
- Rely on the test matrix to run tests
- Simplified container build to make minimal for build and runtime
  and use wheel from 'dist': only publish to GHCR for tagged builds
- Create separate requirements-*.txt for each of the test matrix
- Fix actions-gh-pages version and don't run it for dependabot
- Move Dockerfile to .devcontainer and use as context to improve
  build times
- Other minor improvements and simplifications
JoshuaAppleby and others added 10 commits April 13, 2023 15:39
README.rst Outdated Show resolved Hide resolved
@aawdls
Copy link
Contributor Author

aawdls commented May 4, 2023

I also need to re-enable the code CI

@aawdls
Copy link
Contributor Author

aawdls commented May 4, 2023

The docs build is failing with

  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/importlib/metadata/__init__.py", line 565, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for coniql

but it does not do this locally so I will compare what I am doing to the docs CI.

Edit: fixed with correcting the dist name in pyproject.toml

Distribution name incorrect in pyproject.toml
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #52 (fc4e5db) into master (e9e08e0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   93.28%   93.32%   +0.04%     
==========================================
  Files          10       10              
  Lines         804      809       +5     
==========================================
+ Hits          750      755       +5     
  Misses         54       54              
Impacted Files Coverage Δ
src/coniql/app.py 69.84% <ø> (ø)
src/coniql/__init__.py 100.00% <100.00%> (ø)
src/coniql/caplugin.py 92.59% <100.00%> (ø)
src/coniql/plugin.py 84.37% <100.00%> (ø)
src/coniql/simplugin.py 95.06% <100.00%> (ø)

@AlexanderWells-diamond AlexanderWells-diamond changed the title Draft: Update skeleton Update skeleton May 9, 2023
@AlexanderWells-diamond
Copy link
Contributor

I've fixed the CI, as well as a few miscellaneous formatting issues and black/mypy issues. I think this is ready.

Note that we still need to rename master -> main, and migrate the whole repo to DiamondLightSource.

@AlexanderWells-diamond AlexanderWells-diamond merged commit fc4e5db into master May 22, 2023
@AlexanderWells-diamond AlexanderWells-diamond deleted the update-skeleton branch May 22, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants