Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues seen in testing on beamline #281

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Jan 8, 2024

Fixes #278

Instructions to reviewer on how to test:

  1. Comment out the zocalo results and pin tip detect devices (see Fix i03 system tests #261)
  2. Run python tests/system_tests/test_i03_system.py and confirm they pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77cdfe9) 89.77% compared to head (9fafa14) 89.77%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          81       81           
  Lines        2993     2993           
=======================================
  Hits         2687     2687           
  Misses        306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dperl-dls dperl-dls self-assigned this Jan 9, 2024
Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, devices successfully connect now, thanks!

@DominicOram DominicOram merged commit 02d4299 into main Jan 11, 2024
16 checks passed
@DominicOram DominicOram deleted the 278_fixes_from_testing branch January 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues seen from testing on i03 05/01
2 participants