Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type on attenuator #572

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix type on attenuator #572

merged 2 commits into from
May 28, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #571

Instructions to reviewer on how to test:

  1. Comment out the panda and pin tip detection from i03.py
  2. Run the i03 system tests on main and they fail, run them here and confirm they now pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly

olliesilvester
olliesilvester approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass with this change, using the new dodal connect i03

@DominicOram DominicOram merged commit 51c2881 into main May 28, 2024
11 checks passed
@DominicOram DominicOram deleted the 571_attenuator_wrong_type branch May 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliesilvester olliesilvester olliesilvester approved these changes

@rtuck99 rtuck99 Awaiting requested review from rtuck99

@dperl-dls dperl-dls Awaiting requested review from dperl-dls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_calculated_filter_states in Attenuator wrong type
2 participants
@DominicOram @olliesilvester