Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(hyperion#1307) change DetectorParams detector_size_constants validator to allow the declared type #588

Merged

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented May 30, 2024

Change to address PR comment in DiamondLightSource/hyperion#1307

Instructions to reviewer on how to test:

Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. No one other than i03 is using this so we don't necessarily need to keep both behaviours, I think it's not too much overhead to keep for now though

…e_constants validator to allow the declared type
@rtuck99 rtuck99 force-pushed the hyperion_1307_remove_detector_param_from_hyperion_req_params branch from e0d9c48 to 564f970 Compare June 12, 2024 15:06
@rtuck99 rtuck99 merged commit b63fb1b into main Jun 12, 2024
11 checks passed
@rtuck99 rtuck99 deleted the hyperion_1307_remove_detector_param_from_hyperion_req_params branch June 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants