Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DCM soft signal #621

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Fix DCM soft signal #621

merged 4 commits into from
Jun 17, 2024

Conversation

callumforrester
Copy link
Contributor

@callumforrester callumforrester commented Jun 13, 2024

Fixes #622

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@callumforrester callumforrester marked this pull request as ready for review June 17, 2024 10:37
@DiamondJoseph DiamondJoseph merged commit 9b1cc53 into main Jun 17, 2024
11 checks passed
@DiamondJoseph DiamondJoseph deleted the fix-dcm-read branch June 17, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to read from DCM
2 participants