Add function to save a thumbnail #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rtuck99
reviewed
Jun 18, 2024
| @@ -49,6 +50,9 @@ def _save_image(self, image: Image.Image): | |||
|
|
|||
| LOGGER.info(f"Saving image to {path}") | |||
| image.save(path) | |||
|
|
|||
| save_thumbnail(Path(path), image) | |||
|
|
|||
There was a problem hiding this comment.
PIL documentation states that this modifies the image, but looks like we are ok in all our usages.
There was a problem hiding this comment.
Yh, I thought about doing the copy but didn't seem worth it as we're always calling after saving the original. Thanks for checking though.
rtuck99
added a commit
to DiamondLightSource/hyperion
that referenced
this pull request
Jul 16, 2024
rtuck99
added a commit
to DiamondLightSource/hyperion
that referenced
this pull request
Jul 16, 2024
rtuck99
added a commit
to DiamondLightSource/hyperion
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628
Note that this will only be needed for a month or so, no need to review too heavily.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}