Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApertureScatterguard now set using a well defined enum #755

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

DominicOram
Copy link
Contributor

Fixes #740

Instructions to reviewer on how to test:

  1. Confirm interface to ApertureScatterguard is cleaner
  2. Confirm tests still pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@696ccf0). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage        ?   94.44%           
=======================================
  Files           ?      114           
  Lines           ?     4588           
  Branches        ?        0           
=======================================
  Hits            ?     4333           
  Misses          ?      255           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on the other PR, otherwise looks good

@DominicOram DominicOram merged commit b39f55c into main Aug 20, 2024
18 checks passed
@DominicOram DominicOram deleted the 740_clean_up_aperture_scatterguard_api branch August 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up aperture scatterguard interface
2 participants