Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three modifications: Handling of overloaded pixels, signed data arrays and image number offsets #25

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Three modifications: Handling of overloaded pixels, signed data arrays and image number offsets #25

wants to merge 6 commits into from

Conversation

CV-GPhL
Copy link

@CV-GPhL CV-GPhL commented Dec 8, 2021

Here are three changes/modifications:

  1. Invalid pixels not present/marked in the pixel mask can be reset to an overload marker if environment variable DURIN_RESET_UNMASKED_PIXEL is defined
  2. More explicit handling of (potentially) signed/unsigned data arrays
  3. To allow for a distinction between a numerical image name and its ordinal within the data arrays: allow for environment variable DURIN_IMAGE_NUMBER_OFFSET to define the difference (so that we can fetch data for image "1001" when this is the first image of the data array)

Any comments appreciated ;-)

@CV-GPhL
allow for image offset via DURIN_IMAGE_NUMBER_OFFSET environment
9e7d609 
variable
@CV-GPhL
Resolved merge conflicts
0f27832
@CV-GPhL
Better handling of (usually) unsigned data arrays when calling routine
77d2b84 
to convert to (signed) int and apply pixel mask. The environment
variable DURIN_RESET_UNMASKED_PIXEL can now be used to set non-masked
saturated pixels in order to process them correctly with e.g. XDS.
@graeme-winter graeme-winter self-requested a review December 8, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme-winter graeme-winter Awaiting requested review from graeme-winter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@CV-GPhL