This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Systematise organisation of internal interaction and callbacks #413
Labels
rotation scan
Preparing for implementation of rotation scans
Comments
dperl-dls
added a commit
that referenced
this issue
Dec 5, 2022
dperl-dls
added a commit
that referenced
this issue
Dec 5, 2022
dperl-dls
added a commit
that referenced
this issue
Dec 5, 2022
dperl-dls
added a commit
that referenced
this issue
Dec 5, 2022
dperl-dls
added a commit
that referenced
this issue
Dec 5, 2022
noemifrisina
pushed a commit
to DiamondLightSource/dodal
that referenced
this issue
Jan 18, 2023
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, we have a situation where
zocalo_interaction
contains the interaction and the callback code, whilewrite_nexus
andispyb_interaction
are independent, and the ispyb and nexus callbacks are together in one file. this is horribly unsystematic.I propose that we separate the zocalo callback back out from the zocalo interaction file, and split up the callbacks from each other, so that:
zocalo_interaction
ispyb_interaction
write_nexus
gridscan_ispyb_callback
,rotation_zocalo_callback
etc.That way it's the same for everything, we minimise duplication of code for the actual interactions, and minimise checking what the experiment is in the callback, just subscribe to the correct one in the plan.
Any thoughts?
The text was updated successfully, but these errors were encountered: