Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Systematise organisation of internal interaction and callbacks #413

Closed
dperl-dls opened this issue Dec 2, 2022 · 0 comments · Fixed by #416
Closed

Systematise organisation of internal interaction and callbacks #413

dperl-dls opened this issue Dec 2, 2022 · 0 comments · Fixed by #416
Assignees
Labels
rotation scan Preparing for implementation of rotation scans

Comments

@dperl-dls
Copy link
Collaborator

Currently, we have a situation where zocalo_interaction contains the interaction and the callback code, while write_nexus and ispyb_interaction are independent, and the ispyb and nexus callbacks are together in one file. this is horribly unsystematic.

I propose that we separate the zocalo callback back out from the zocalo interaction file, and split up the callbacks from each other, so that:

  • all the code needed for zocalo interaction (for any type of experiment) is in zocalo_interaction
  • all the code needed for ispyb interaction (for any type of experiment) is in ispyb_interaction
  • all the code needed for nexus writing (for any type of experiment) is in write_nexus
  • and the callbacks are all individual for experiment type, eg: gridscan_ispyb_callback, rotation_zocalo_callback etc.

That way it's the same for everything, we minimise duplication of code for the actual interactions, and minimise checking what the experiment is in the callback, just subscribe to the correct one in the plan.

Any thoughts?

@dperl-dls dperl-dls self-assigned this Dec 5, 2022
@dperl-dls dperl-dls added the rotation scan Preparing for implementation of rotation scans label Dec 5, 2022
dperl-dls added a commit that referenced this issue Dec 5, 2022
dperl-dls added a commit that referenced this issue Dec 5, 2022
dperl-dls added a commit that referenced this issue Dec 5, 2022
dperl-dls added a commit that referenced this issue Dec 5, 2022
dperl-dls added a commit that referenced this issue Dec 5, 2022
noemifrisina pushed a commit to DiamondLightSource/dodal that referenced this issue Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rotation scan Preparing for implementation of rotation scans
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant