Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ispyb.model.detector.Detector model #100

Merged
merged 7 commits into from
May 19, 2020
Merged

Add ispyb.model.detector.Detector model #100

merged 7 commits into from
May 19, 2020

Conversation

rjgildea
Copy link
Contributor

Provide access from DataCollection model via detector attribute.

For https://jira.diamond.ac.uk/browse/SCI-9088

@rjgildea
Add ispyb.model.detector.Detector model
afdb841 
Provide access from DataCollection model via detector attribute.
@coveralls
Copy link

coveralls commented May 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 82.447% when pulling 869fe91 on detector_model into 4bb6496 on master.

Anthchirp
Anthchirp approved these changes May 18, 2020
View reviewed changes
ispyb/model/datacollection.py Outdated Show resolved Hide resolved
ispyb/model/detector.py Outdated Show resolved Hide resolved
@rjgildea rjgildea merged commit 06a5506 into master May 19, 2020
@rjgildea rjgildea deleted the detector_model branch May 19, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarlLevik KarlLevik KarlLevik left review comments

@Anthchirp Anthchirp Anthchirp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rjgildea @coveralls @KarlLevik @Anthchirp