Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt insert_motion_correction() to take parameters like insert_ctf(). #147

Merged
merged 7 commits into from
Apr 19, 2021
Merged

Adapt insert_motion_correction() to take parameters like insert_ctf(). #147

merged 7 commits into from
Apr 19, 2021

Conversation

HorstmannA
Copy link
Contributor

Follow the format of insert_ctf()

Anthchirp
Anthchirp approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the spirit of #105, and also a breaking API change.
Does anyone use these functions at ESRF?

@stufisher
Copy link
Contributor

Not afaik, EM is all dealt with via webservices

@Anthchirp
Copy link
Contributor

Excellent. We'll make this into a point release then (as before)

@HorstmannA HorstmannA merged commit 0c287cf into master Apr 19, 2021
@HorstmannA HorstmannA deleted the insert-motion-corr-rewrite branch April 19, 2021 15:10
Anthchirp pushed a commit that referenced this pull request Apr 19, 2021
@HorstmannA @Anthchirp
Adapt insert_motion_correction() to take parameters (#147)
24ebcfa 
like insert_ctf().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anthchirp Anthchirp Anthchirp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HorstmannA @stufisher @Anthchirp