Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalog-info for dev portal #201

Merged
merged 2 commits into from
May 26, 2023
Merged

Add catalog-info for dev portal #201

merged 2 commits into from
May 26, 2023

Conversation

rjgildea
Copy link
Contributor

No description provided.

@rjgildea rjgildea requested a review from garryod May 26, 2023 08:48
@rjgildea
Copy link
Contributor Author

@garryod the catalog import tool is returning the following error, but it's not obvious to me what it means:

{"error":{"name":"NotAllowedError","message":"This operation not allowed in readonly mode"},"request":{"method":"POST","url":"/locations"},"response":{"statusCode":403}}

@garryod
Copy link
Member

garryod commented May 26, 2023

@garryod the catalog import tool is returning the following error, but it's not obvious to me what it means:

{"error":{"name":"NotAllowedError","message":"This operation not allowed in readonly mode"},"request":{"method":"POST","url":"/locations"},"response":{"statusCode":403}}

Yes, it will do this. The import functionality is disabled as we want to force all entries to be made via a discovery agent (i.e. from a catalog-info.yaml in a git repo). I should at some point re-work the front end to reflect that it only serves as a validation utility.

Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to replace the link with an diamond.ac.uk/viewdocs-url entry in metadata.annotations. This will embed them as an <iframe> in the dev portal 'Docs' tab.
A human readable name in the metadata.title would also be good.

@rjgildea rjgildea requested a review from garryod May 26, 2023 09:19
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjgildea rjgildea merged commit 9801ee1 into main May 26, 2023
@rjgildea rjgildea deleted the catalog-info branch May 26, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants