Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a device multiple commands at once #77

Closed
MattPrit opened this issue Aug 4, 2022 · 0 comments · Fixed by #82
Closed

Send a device multiple commands at once #77

MattPrit opened this issue Aug 4, 2022 · 0 comments · Fixed by #82
Assignees
@MattPrit

Comments

@MattPrit
Copy link
Collaborator

MattPrit commented Aug 4, 2022

Currently the command interpreter can only handle one command at a time. In the case of the example shutter device, this means that T? P? is not a valid command, whereas T? and P? are individually. This is significant because in the case of some real world devices, e.g. a PMAC, EPICs will send multiple commands to the device on a single line.
@MattPrit MattPrit self-assigned this Aug 4, 2022
MattPrit added a commit that referenced this issue Aug 11, 2022
@MattPrit
#77: Move async iterable wrapper function to utils
79319e3
MattPrit added a commit that referenced this issue Aug 11, 2022
@MattPrit
#77: Add SplittingInterpreter classes and tests
7887f41
@MattPrit MattPrit mentioned this issue Aug 11, 2022
Merged
@DominicOram DominicOram mentioned this issue Aug 11, 2022
Closed
MattPrit added a commit that referenced this issue Aug 12, 2022
@MattPrit
#77:Remove SplittingInterpreter Sync/Async subclasses
2dce8c9
MattPrit added a commit that referenced this issue Aug 12, 2022
@MattPrit
#77: Tidy up SplittingInterpreter __init__ docstrings
48a3c40
MattPrit added a commit that referenced this issue Aug 12, 2022
@MattPrit
#77: Improve test coverage of splitting_interpreter.py
f3cd583
MattPrit added a commit that referenced this issue Aug 12, 2022
@MattPrit
#77: Ignore D107 rather than D105 on overloaded SplittingInterpreter …
0edb090 
…__init__
MattPrit added a commit that referenced this issue Aug 12, 2022
@MattPrit
#77: Allow SplittingInterpreter to split using a regex delimiter
e6bce1d
MattPrit added a commit that referenced this issue Aug 12, 2022
@MattPrit
#77: Add multi response test and rename response collection method
c2e3964
@DominicOram DominicOram mentioned this issue Aug 16, 2022
Closed
MattPrit added a commit that referenced this issue Aug 17, 2022
@MattPrit
#77: Add response delimiter and handle the no sub-message case; updat…
280cc57 
…e tests
MattPrit added a commit that referenced this issue Aug 17, 2022
@MattPrit
#77: Fix SplittingInterpreter.handle docstring
9906aa4
MattPrit added a commit that referenced this issue Aug 22, 2022
@MattPrit
#77: Small refactor of SplittingInterpreter
d89b586
MattPrit added a commit that referenced this issue Aug 30, 2022
@MattPrit
#77: SplittingInterpreter: Change individual_messages list comp. to u…
74e0227 
…se 'is not None'
MattPrit added a commit that referenced this issue Aug 30, 2022
@MattPrit
#77: Remove tests for empty string removal when splitting
8b919dc
@MattPrit MattPrit mentioned this issue Aug 30, 2022
Closed
MattPrit added a commit that referenced this issue Aug 31, 2022
@MattPrit
#77: SplittingInterpreter: remove check for empty messsage list
b1ae0e6
MattPrit added a commit that referenced this issue Aug 31, 2022
@MattPrit
#77: Add MultiCommandInterpreter
f38dfbe
MattPrit added a commit that referenced this issue Aug 31, 2022
@MattPrit
#77: MultiCommandInterpreter: Fix typing typo
17e9e86
@MattPrit MattPrit mentioned this issue Aug 31, 2022
Closed
MattPrit added a commit that referenced this issue Sep 5, 2022
@MattPrit
#77: Refactor to remove some typing issues
490a25a
MattPrit added a commit that referenced this issue Sep 5, 2022
@MattPrit
#77: Add functional MultiCommandInterpreter
5882a2e
MattPrit added a commit that referenced this issue Sep 5, 2022
@MattPrit
#77: Remove joining logic from SplittingInterpreter
978ad89
MattPrit added a commit that referenced this issue Sep 7, 2022
@MattPrit
#77: Refactor MultiCommandInterpreter.handle
f3599ba
MattPrit added a commit that referenced this issue Sep 7, 2022
@MattPrit
#77: Refactor and add tests for MultiCommandInterpreter
4410156
MattPrit added a commit that referenced this issue Sep 7, 2022
@MattPrit
#77: JoiningInterpreter tests: make flake8 happy
f246fac
MattPrit added a commit that referenced this issue Sep 7, 2022
@MattPrit
#77: Small refactor of SplittingInterpreter and utils
2a0ad1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattPrit MattPrit

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@MattPrit