Fix type errors caught by pyright but not mypy #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 94.50% 94.42% -0.08%
==========================================
Files 44 44
Lines 1292 1310 +18
==========================================
+ Hits 1221 1237 +16
- Misses 71 73 +2
|
tpoliaw
force-pushed
the
pyright_errors
branch
2 times, most recently
from
1b3ff04
to
5271a2b
Compare
callumforrester
approved these changes
Jul 14, 2023
| @@ -21,7 +21,7 @@ def __init__( | |||
| self, | |||
| host: str = "127.0.0.1", | |||
| port: int = 5555, | |||
| socket_factory: Optional[SocketFactory] = create_zmq_push_socket, | |||
| socket_factory: SocketFactory = create_zmq_push_socket, | |||
There was a problem hiding this comment.
Good spot, should probably also do this in the base class
|
There are still a few (6) errors remaining but mostly around the interpreters which I'd like to overhaul slightly anyway |
The class variables are types rather than instances in their own right so should be typed as such. This allows type checkers to correctly check key lookups.
Iterators are iterable but the more specific type allows callers to use additional methods.
Methods are generated dynamically so static type checking can't work.
tpoliaw
changed the title
tpoliaw
commented
Jul 24, 2023
abbiemery
reviewed
Jul 24, 2023
|
Up to you but I think I'd go for a separate PR so it can be rolled back more easily if there's a pyright problem we can't work around. Everything in this PR should still be valid if we stick with mypy. |
|
Agree. In which case either resolve the issue in the push device or make a new issue for it, and merge this :) |
abbiemery
approved these changes
Jul 24, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeas type of Inputs/Outputs fieldsWhere type checking has been ignored, comments have been added to explain
why the code is still valid.