Catch HTTP adapter run_forever failures in test fixture #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 44 44
Lines 1310 1310
=======================================
Hits 1245 1245
Misses 65 65 |
rosesyrett
changed the title
tpoliaw
reviewed
Jul 24, 2023
tpoliaw
approved these changes
Jul 25, 2023
added 3 commits
July 25, 2023 14:39
abbiemery
force-pushed
the
fix-hanging-http-tests
branch
from
acb6db2
to
539d44d
Compare
abbiemery
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master, running pytest if port 8080 on localhost is bound freezes the output. The terminal simply hangs. I have investigated the issue and fixed this by changing the fixture where this is happening so that it keeps track of the task that calls
.run_foreveron the adaptor as well as.wait_until_readyand waits until one of those completes.wait_until_ready will only ever be set if run_forever gets far enough to set it; if, for example, the server cannot be instantiated, this fails silently, and wait_until_ready therefore waits forever.