Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error detecting subtitle language as english #29

Open
mattmac24 opened this issue Jul 23, 2017 · 2 comments
Open

Error detecting subtitle language as english #29

mattmac24 opened this issue Jul 23, 2017 · 2 comments
Assignees
Labels

Comments

@mattmac24
Copy link

I am having trouble with enzyme detecting the first(or maybe just english?) embedded subtitle language. This seems to be happening with all of my files so is it somehow possible that this is a result of something in my setup? I originally reported this as a bug with nzbget-subliminal but @caronc has helped me realise the actual problem lies with enzyme here. Apologies, but I am not sure how to get further debugging information from enzyme to help.

An example file I am talking about is: Game.of.Thrones.S05E01.The.Wars.to.Come.1080p.WEB-DL.DD5.1.H.264-NTb
ffprobe output: https://pastebin.com/iQVU4whX
mediainfo output: https://pastebin.com/BtUNSRjf
but the enzyme output is:

python test.py /home/matt/subliminal_test/Game.of.Thrones.S05E01.The.Wars.to.Come.1080p.WEB-DL.DD5.1.H.264-NTb.mkv /home/matt/subliminal_test/Game.of.Thrones.S05E01.The.Wars.to.Come.1080p.WEB-DL.DD5.1.H.264-NTb.mkv {'forced': False, 'name': None, 'language': None, 'default': False, 'enabled': True, 'number': 3, 'codec_name': None, 'codec_id': u'S_TEXT/UTF8', 'lacing': False, 'type': 17}

Another example is:
mediainfo output: https://pastebin.com/xS7B4L78
ffprobe output: https://pastebin.com/69bCLQ75
enzyme output is:
American Horror Story - S05E01 - Checking In (Bluray-1080p - x264 DTS [EN+FR+DE+JA+ES]).mkv {'forced': False, 'name': None, 'language': None, 'default': False, 'enabled': True, 'number': 3, 'codec_name': None, 'codec_id': u'S_HDMV/PGS', 'lacing': False, 'type': 17} {'forced': False, 'name': None, 'language': u'fre', 'default': False, 'enabled': True, 'number': 4, 'codec_name': None, 'codec_id': u'S_HDMV/PGS', 'lacing': False, 'type': 17} {'forced': False, 'name': None, 'language': u'ger', 'default': False, 'enabled': True, 'number': 5, 'codec_name': None, 'codec_id': u'S_HDMV/PGS', 'lacing': False, 'type': 17} {'forced': False, 'name': None, 'language': u'jpn', 'default': False, 'enabled': True, 'number': 6, 'codec_name': None, 'codec_id': u'S_HDMV/PGS', 'lacing': False, 'type': 17} {'forced': False, 'name': None, 'language': u'spa', 'default': False, 'enabled': True, 'number': 7, 'codec_name': None, 'codec_id': u'S_HDMV/PGS', 'lacing': False, 'type': 17}

Any help with getting this fixed would be fantastic :)

@aulemahal
Copy link
Contributor

You are right! This is not really a bug but enzyme does not follow the Matroska specs on this. As can be read here, the Language EBML element should have eng as a default value, not None.

aulemahal added a commit to aulemahal/enzyme that referenced this issue Jul 25, 2017
@Diaoul Diaoul self-assigned this Jul 25, 2017
@Diaoul Diaoul added the bug label Jul 25, 2017
aulemahal added a commit to aulemahal/enzyme that referenced this issue Jul 26, 2017
This reverts commit 30b3a60.
This will be in another pull request.
@mattmac24
Copy link
Author

Thank you for the great work and solving this so quickly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants