Update guessit to 2.0 #564
Conversation
| @@ -66,7 +66,7 @@ def get_matches(self, video, hearing_impaired=False): | |||
| if video.title and sanitized_string_equal(self.series_title, video.title): | |||
| matches.add('title') | |||
| # guess | |||
| matches |= guess_matches(video, guess_episode_info(self.movie_release_name + '.mkv')) | |||
| matches |= guess_matches(video, guessit(self.movie_release_name + '.mkv', {'type': 'episode'})) | |||
There was a problem hiding this comment.
No, it can be dropped.
Le 26 janv. 2016 23:48, "Antoine Bertin" notifications@github.com a
écrit :
In subliminal/providers/opensubtitles.py
#564 (comment):@@ -66,7 +66,7 @@ def get_matches(self, video, hearing_impaired=False):
if video.title and sanitized_string_equal(self.series_title, video.title):
matches.add('title')
# guess
matches |= guess_matches(video, guess_episode_info(self.movie_release_name + '.mkv'))matches |= guess_matches(video, guessit(self.movie_release_name + '.mkv', {'type': 'episode'}))Do we still need the extension?
—
Reply to this email directly or view it on GitHub
https://github.com/Diaoul/subliminal/pull/564/files#r50914250.
|
Thanks for the PR, I left some inline comments. I can see some tests are failing, I'll look into it tomorrow. |
|
Ok, i've fixed remaining tests and made some changes with comments you have made (removed .mkv extensions, removed invalid link to inexistant rebulk docs). It should works now ! |
|
Do you plan a release after merging this one ? Would be great for Flexget and SickRage projects :p |
|
There are still issues with python 2.7,i'll fix them. I'll also release guessit as 2.0 final. |
|
I'm currently working on proper string support in both python 2 & python 3 in guessit. This will fix remaining failing test. |
|
All is OK now ! |
|
Requirements should be >=2.0.3 because of an issue with unicode handling. |
Work in progress...
This is the first attempt for #550. There are a few tests failing, I don't have time to fix them for now, but feel free to comment the PR !