Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn #template select in to menu with submenus, add current template to url #41

Merged
merged 11 commits into from
Mar 14, 2019
Merged

Turn #template select in to menu with submenus, add current template to url #41

merged 11 commits into from
Mar 14, 2019

Conversation

soryy708
Copy link
Contributor

No description provided.

@soryy708 soryy708 requested a review from Dibasic as a code owner March 14, 2019 18:34
@soryy708 soryy708 mentioned this pull request Mar 14, 2019
Closed
@soryy708
Copy link
Contributor Author

Removed the select box. Now clicking on the "load template" button opens the menu.

@soryy708
Copy link
Contributor Author

Incidentally, this PR makes it possible to load files in Firefox. Down with the Edge monopoly!

@soryy708
Copy link
Contributor Author

@Dibasic Fixed conflict.

@soryy708
Copy link
Contributor Author

image

Dibasic
Dibasic requested changes Mar 14, 2019
View reviewed changes
Copy link
Owner

@Dibasic Dibasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. At a minimum, before merging, let's get collapseAll implemented and use the old anchor syntax.

script/templates.js Show resolved Hide resolved
script/templates.js Outdated Show resolved Hide resolved
script/templates.js Show resolved Hide resolved
@Dibasic
Copy link
Owner

Dibasic commented Mar 14, 2019

Also, no clue how this is getting around FireFox' CORS policy, but it certainly is. It's still using $.get() which is an AJAX request like any other.

@soryy708
Copy link
Contributor Author

@Dibasic the $.get() request now treats the resource as text, which is allowed by CORS policy on firefox.

@Dibasic Dibasic added enhancement New feature or request changes requested Further changes are needed labels Mar 14, 2019
@soryy708
Copy link
Contributor Author

@Dibasic Done. Ready for review.

Dibasic
Dibasic reviewed Mar 14, 2019
View reviewed changes
Copy link
Owner

@Dibasic Dibasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I think getting rid of #copy and having the URL update is more intuitive.

Would you be able to make these avoid wrapping into multiple lines so that each menu item is the same height?
image

@soryy708 soryy708 changed the title Turn #template select in to menu with submenus Turn #template select in to menu with submenus, add current template to url Mar 14, 2019
@Dibasic
Copy link
Owner

Dibasic commented Mar 14, 2019

Looks great.

@Dibasic Dibasic merged commit a377898 into Dibasic:master Mar 14, 2019
@soryy708 soryy708 deleted the submenus branch March 14, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dibasic Dibasic Dibasic approved these changes

Assignees
No one assigned
Labels
changes requested Further changes are needed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soryy708 @Dibasic