(#104) Add Leaderboard Functionality #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JyotinderSingh
force-pushed
the
leaderboard
branch
from
2525dc4
to
19faf7b
Compare
JyotinderSingh
force-pushed
the
leaderboard
branch
from
19faf7b
to
d3c68a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Leaderboard functionality, similar to Redis Leaderboard Overview.
The leaderboard is implemented using a Sorted Set backed by a SkipList implementation.
Instead of storing the actual strings for keys, we store pointers to these keys. Similarly for the values, we only store pointers to the actual values stored in the
store. This allows us to keep the data structure space efficient.We also need to make sure that the KV pairs stored in the ZSet do not collide with the KV pairs in the general store.
Issue
#104
How was the patch tested?
Added unit tests + existing tests