Added support for arm64 platform; fixes BGREWRITEAOF for arm64 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More changes are impending in this PR. Kindly don't review it now. |
|
@rohanverma94 Are you still planning to work on the remaining changes? |
|
I'm occupied with some stuff. I would've resumed this work otherwise. Meanwhile feel free to close this or may be raise new PR. May be I will join next rounds of dicussion in context of current roadmap for dicedb. |
|
Is this not merged yet ? Still facing the same issue on M1(arm64). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arm64 platform the fork() is not available hence we use clone() system call to implement a copy-on-write. This has been tested on arm64 Linux.
On m1(aarch64/arm64), this may work fine. It would be good if someone having an M1 can test and provide any valuable inputs.
Fixes #58 and #17