Complete the annotations in pip/_internal/cli
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the second part of my job made on pypa#10018, where I must complete all the annotations from `pip/_internal/cli`.
This is the news file for my pull request.
I just changed one function annotations, on line 121.
Just update the annotations according to the CI last failure.
I wanted to use "RequirementPreparer", not "RequirementParser".
There were some previous errors with this, but now I fixed them.
It is not exactly a problem, it's just to pass the CI.
They fail on the CI checks.
Convert type commentaries into annotations.
Fix also the original annotation instead of just copying it. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Some of the annotations were incorrect.
It is "self._session: Optional[PipSession] = None" instead of "self._session = None # type: Optional[PipSession]".
They were imported but unused.
One of them was incorrect.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of my job made on pypa#10018, where I must complete all the annotations from
pip/_internal/cli.