-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
includeError
displaying errors as "[Array]"
#278
Comments
Hi, since we recently went through a breaking update, it would be helpful to know which version of the package you're using. |
@spawnia it seems like you removed the following code in the rewrite: I think adding this back would resolve the issue. At the very least, it will format the error better. |
The operation name and type indicate this is definitely version 3. I will begin working on a PR to restore nice serialization of errors right now. |
Thank you @DiederikvandenB @spawnia, I can now see the errors formatted correctly! I have a follow up question and it might be a feature request. I can see the error nicely now but if I wanted to see the results I would have to enable |
How about |
I like that idea |
How does Apollo Client behave when it receives a 200 that also has |
I'm not sure, I would need to test it out. For now I'm able to see graphQL errors by adding a breadcrumb in a errorLink. If we could follow that, I think that would work for me. Also I had to disable transaction name in the plugin because it would override every error. For example I threw an error in a button and it would set the operation name to the query when the query was successful (the second issue is what it should look like). I think it makes sense to scope many of these options to errors. I have For completeness, here is my config for const sentryLink = new SentryLink({
setFingerprint: false,
setTransaction: false,
attachBreadcrumbs: {
includeQuery: true,
includeError: true,
},
}) |
@alesso-x you have some valid points, but could you open discrete issues? I think that would be more productive than us discussing in this closed issue 😉 |
I'm having an issue where the errors are shown as
"[Array]"
, is there a way to map this appropriately? I had to add my own breadcrumb witherrorLink
. Thank you in advance, great package so far!The text was updated successfully, but these errors were encountered: