Improve breadcrumb data serialization and handling of ServerError.result #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #278
The first part towards solving this issue is recognizing when a thrown error includes a result. I think the correct thing to do in that case is to respect the value of the
includeFetchResult
configuration and act accordingly.The second part would be to do deep serialization of certain parts of the breadcrumb. I am not quite sure how that is best handled, especially when considering
attachBreadcrumbs.transform
- this function expects a breadcrumb that still holds structured data, that should be the most useful to work with. Should we just JSON-stringify every key of the transformed breadcrumb afterwards?