Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip known/already downlaoded URL's! #398

Closed
CuddleBear92 opened this issue Feb 6, 2021 · 1 comment
Closed

Skip known/already downlaoded URL's! #398

CuddleBear92 opened this issue Feb 6, 2021 · 1 comment
Milestone

Comments

@CuddleBear92
Copy link

The download system should save and map the urls of any download it does (not parse of metadata) and map it to the file-id it has internally.
This way you can more easily skip known urls. It could enable the system to skip known files that the user already has. If you want to verify if the file is in place or not then you could do that too.

This could also enable a way to re-download missing files or corrupted files.
If a file does not open for whatever reason then it could trigger a re-download of the file.

But doing it this way will speed up the time it takes to process already imported files instead of downloading the full file then only to realise it already has the file in place like it does now.

Looking up the url on the url database/list is faster than downloading the file again, also lighter on the server.
Even looking up the url AND verifying the file is in its correct location is faster than downloading the file again.
Think this is the way to go.

@Difegue
Copy link
Owner

Difegue commented Feb 8, 2021

I've been toying with a browser extension ala Hydrus Companion and do kind of need something like that -- I initially planned to just use the Source Finder script that's already bundled, but since it parses metadata for source: tags on each run it's just super slow.

I don't like adding extra stuff to the database since it means more maintenance and migration pains, but a basic URL<->ID index would indeed be useful here.

@Difegue Difegue added this to the 0.7.8 milestone Mar 29, 2021
Difegue added a commit that referenced this issue Mar 30, 2021
+ Update sourcefinder to use it as well
@Difegue Difegue closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants