Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the .pid files for Hypnotoad/Minion/Shinobu outside of /script #469

Closed
Difegue opened this issue May 7, 2021 · 1 comment
Closed

Comments

@Difegue
Copy link
Owner

Difegue commented May 7, 2021

The app currently freezes the Proc::Simple objects for both Shinobu and Minion processes into shinobu/minion.pid files in the app's working directory, which is usually /script. This behavior was implemented kinda following what Hypnotoad was already doing with its own .pid file.

This can fail if the directory is write-protected(like in brew tests), so it'd be better to move those files to /tmp, which probably fits better anyway since they're transient.

For Hypnotoad, it'll be necessary to modify launcher.pl in order to set pid_file:
https://docs.mojolicious.org/Mojo/Server/Hypnotoad#pid_file

@Difegue
Copy link
Owner Author

Difegue commented Jun 1, 2021

.pid files are now in the application's temporary directory, which can be moved thanks to LRR_TEMP_DIRECTORY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant