-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: Cannot add tags on chromium-based browsers #531
Comments
Weird, I'll admit I mostly test on Firefox but I feel the problem would've come up way earlier if this was a common issue. Do you get anything special in the developer console when trying to add/save tags? |
Pulling up my library on a computer to check logs and using my phone to add tags I noted the following: Edit: Slightly misread your comment. I loaded up LRR on a chrome browser on my phone and used the remote debugger on my computer to view a developer console. As far as I'm concerned, nothing popped up in the console upon pressing save. In network tab, I noticed an instance of "metadata" would return with status 200. So from the browser it looks like it's successfully posting? One more edit: Made 3 AVDs to test: 1 on android 8, 1 on android 11, and another on android 12. With both android 8 and 11, I had the same issue as above, where tags were not saving. However, on android 12, I was able to add a comma and the tag would be saved, I could even open up the archive on my computer and verify the tag had been saved. |
I'm guessing tagger.js is a bit too advanced for mobile; As a preventive measure I've disabled it for mobile useragents so it falls back on the old basic textfield, which at least works. 💯 |
LRR Version and OS
LRR version 0.8.1, Ubuntu server 18.04, android version 11
Bug Details
Currently, on any chromium based browser such as chrome, bromite, or even the default android webview browser, adding new tags does not work. I can type into the box, but when I click save, nothing recently typed is saved. Checking the logs with debug mode on, I did not see any line indicating that metadata had changed at all. I also noticed that the android keyboard's "enter" key had changed to move on to the next textbox in the page (the import tags one). Attempting to enter tags using a comma to mark the end of a tag also did not help.
This problem does not show up when using Firefox, and I am able to edit tags just fine with that browser. I also noticed that the keyboard's enter key was an actual enter key and didn't move to the next text box.
I don't mind using Firefox to tag my archives but I enjoy using tachiyomi to browse my library and use the built in webview to access the metadata to add tags. This is a mild inconvenience at most.
The text was updated successfully, but these errors were encountered: