Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Option to hide the carousel view in Index #567

Closed
PasserDreamer opened this issue Dec 15, 2021 · 5 comments
Closed

[Suggestion] Option to hide the carousel view in Index #567

PasserDreamer opened this issue Dec 15, 2021 · 5 comments

Comments

@PasserDreamer
Copy link

Please describe your suggestion, and the problem it'd solve.
Please add an option for show/hide "ancient chinese lithographies" in the settings.
Thanks.
123

@PasserDreamer PasserDreamer changed the title Option for hiding "ancient chinese lithographies" [Suggestion]Option for hiding "ancient chinese lithographies" Dec 15, 2021
@Difegue
Copy link
Owner

Difegue commented Dec 15, 2021

👋 Do you mean hiding the carousel UI altogether? The ancient lithographies thing is for the table/thumbnail view below it.

I don't plan on adding a toggle to remove the carousel for the time being since it doesn't take too much space when collapsed.
If you don't find it useful however, I'd like to hear opinions on how it could be improved/more useful, as it is still quite new.

@Difegue Difegue changed the title [Suggestion]Option for hiding "ancient chinese lithographies" [Suggestion] Option to hide the carousel view in Index Dec 15, 2021
@PasserDreamer
Copy link
Author

Yes, I personally prefer simple clean and sad panda style UI.
The carousel is more like a complicated design IMO.

@pandafeliz
Copy link

the carousel seems to choke if you have a lot of untagged archives since it loads them all, and appears to be the same for the new filter, I remember the time I tried it caused a memory leak in the browser since I have around 3k or so archives still marked with the new tag.

I tried hiding it but it seems it still loads the data even collapsed and it doesn't remember the hiding status when you use the search.

@AbyssalMonkey
Copy link

AbyssalMonkey commented Dec 16, 2021

I tried hiding it but ... it doesn't remember the hiding status when you use the search.

This is the most annoying thing to me. I use LRR to act as a host for my phone, and use external readers, since unfortunately, phone browsers are still prone to breaking at the slightest touch compared to desktop browsers and dedicated phone apps. As a result, if I'm using the LRR webapp, it's purely for database management, and the carousel is not helpful with that. So having to collapse it every time I perform a search is tedious.

Difegue added a commit that referenced this issue Dec 22, 2021
…eloads

+ the matching API endpoints won't be called if the carousel is closed
@Difegue
Copy link
Owner

Difegue commented Dec 22, 2021

As of the latest commit, collapsing the carousel will now be remembered on further loads (I should've added this on initial release, but hindsight is 10/10 as they say), and the required API endpoints won't be called if it's collapsed/uninitialized.

As mentioned before, I don't plan on adding functionality to hide the carousel altogether; The redesigned index takes less vertical space than the previous version even with it present. You can use custom CSS on your end if you really want it gone I guess!

@Difegue Difegue closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants